Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor css: modal and offcanvas header spacing #39373

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

MarkoOleksiyenko
Copy link
Contributor

@MarkoOleksiyenko MarkoOleksiyenko commented Nov 7, 2023

Description

PR regarding the discussion https://github.com/orgs/twbs/discussions/39370 about the spacing in the modal (plus offcanvas) header. The space-between is not used anymore as the position of the btn-close is based on the margin now.

Motivation & Context

If the btn-close is removed the content is distributed evenly (space-between behavior), so the wide modals have scattered title if the header is composite (e.g. icon plus text). It is logical to put it to the default setting, which is justify-content: start.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

(not sure whether it is breaking change, but might be, please correct me if I am wrong)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related GH discussion

https://github.com/orgs/twbs/discussions/39370

@MarkoOleksiyenko MarkoOleksiyenko requested a review from a team as a code owner November 7, 2023 09:40
@MarkoOleksiyenko MarkoOleksiyenko force-pushed the header-css branch 3 times, most recently from 17075a6 to 9a909bf Compare November 9, 2023 10:15
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @MarkoOleksiyenko! Neat!

@julien-deramond julien-deramond merged commit 55952bf into twbs:main Nov 15, 2023
14 checks passed
@MarkoOleksiyenko
Copy link
Contributor Author

Thanks for the review @mdo and @julien-deramond !

romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@Batman08
Copy link

If you use the dark variant of the "close" button as show here;
https://getbootstrap.com/docs/5.3/components/close-button/#dark-variant
Then it looks like this change doesn't push the "close" button to the far right.

@XhmikosR
Copy link
Member

@Batman08 you should create a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants